- client: fix upstream DNS servers form

Closes #1000

client/src/reducers/index.js

@@ -15,299 +15,326 @@ import stats from './stats';
 import queryLogs from './queryLogs';
 import filtering from './filtering';
 
-const settings = handleActions({
-    [actions.initSettingsRequest]: state => ({ ...state, processing: true }),
-    [actions.initSettingsFailure]: state => ({ ...state, processing: false }),
-    [actions.initSettingsSuccess]: (state, { payload }) => {
-        const { settingsList } = payload;
-        const newState = { ...state, settingsList, processing: false };
-        return newState;
-    },
-    [actions.toggleSettingStatus]: (state, { payload }) => {
-        const { settingsList } = state;
-        const { settingKey } = payload;
+const settings = handleActions(
+    {
+        [actions.initSettingsRequest]: state => ({ ...state, processing: true }),
+        [actions.initSettingsFailure]: state => ({ ...state, processing: false }),
+        [actions.initSettingsSuccess]: (state, { payload }) => {
+            const { settingsList } = payload;
+            const newState = { ...state, settingsList, processing: false };
+            return newState;
+        },
+        [actions.toggleSettingStatus]: (state, { payload }) => {
+            const { settingsList } = state;
+            const { settingKey } = payload;
 
-        const setting = settingsList[settingKey];
+            const setting = settingsList[settingKey];
 
-        const newSetting = { ...setting, enabled: !setting.enabled };
-        const newSettingsList = { ...settingsList, [settingKey]: newSetting };
-        return { ...state, settingsList: newSettingsList };
-    },
-    [actions.setUpstreamRequest]: state => ({ ...state, processingUpstream: true }),
-    [actions.setUpstreamFailure]: state => ({ ...state, processingUpstream: false }),
-    [actions.setUpstreamSuccess]: state => ({ ...state, processingUpstream: false }),
-
-    [actions.testUpstreamRequest]: state => ({ ...state, processingTestUpstream: true }),
-    [actions.testUpstreamFailure]: state => ({ ...state, processingTestUpstream: false }),
-    [actions.testUpstreamSuccess]: state => ({ ...state, processingTestUpstream: false }),
-}, {
-    processing: true,
-    processingTestUpstream: false,
-    processingSetUpstream: false,
-    processingDhcpStatus: false,
-    settingsList: {},
-});
-
-const dashboard = handleActions({
-    [actions.dnsStatusRequest]: state => ({ ...state, processing: true }),
-    [actions.dnsStatusFailure]: state => ({ ...state, processing: false }),
-    [actions.dnsStatusSuccess]: (state, { payload }) => {
-        const {
-            version,
-            running,
-            dns_port: dnsPort,
-            dns_addresses: dnsAddresses,
-            upstream_dns: upstreamDns,
-            bootstrap_dns: bootstrapDns,
-            all_servers: allServers,
-            protection_enabled: protectionEnabled,
-            language,
-            http_port: httpPort,
-        } = payload;
-        const newState = {
+            const newSetting = { ...setting, enabled: !setting.enabled };
+            const newSettingsList = { ...settingsList, [settingKey]: newSetting };
+            return { ...state, settingsList: newSettingsList };
+        },
+        [actions.setUpstreamRequest]: state => ({ ...state, processingSetUpstream: true }),
+        [actions.setUpstreamFailure]: state => ({ ...state, processingSetUpstream: false }),
+        [actions.setUpstreamSuccess]: (state, { payload }) => ({
             ...state,
-            isCoreRunning: running,
-            processing: false,
-            dnsVersion: version,
-            dnsPort,
-            dnsAddresses,
-            upstreamDns: upstreamDns.join('\n'),
-            bootstrapDns: bootstrapDns.join('\n'),
-            allServers,
-            protectionEnabled,
-            language,
-            httpPort,
-        };
-        return newState;
+            ...payload,
+            processingSetUpstream: false,
+        }),
+
+        [actions.testUpstreamRequest]: state => ({ ...state, processingTestUpstream: true }),
+        [actions.testUpstreamFailure]: state => ({ ...state, processingTestUpstream: false }),
+        [actions.testUpstreamSuccess]: state => ({ ...state, processingTestUpstream: false }),
     },
-
-    [actions.enableDnsRequest]: state => ({ ...state, processing: true }),
-    [actions.enableDnsFailure]: state => ({ ...state, processing: false }),
-    [actions.enableDnsSuccess]: (state) => {
-        const newState = { ...state, isCoreRunning: !state.isCoreRunning, processing: false };
-        return newState;
+    {
+        processing: true,
+        processingTestUpstream: false,
+        processingSetUpstream: false,
+        processingDhcpStatus: false,
+        settingsList: {},
     },
+);
 
-    [actions.disableDnsRequest]: state => ({ ...state, processing: true }),
-    [actions.disableDnsFailure]: state => ({ ...state, processing: false }),
-    [actions.disableDnsSuccess]: (state) => {
-        const newState = { ...state, isCoreRunning: !state.isCoreRunning, processing: false };
-        return newState;
-    },
-
-    [actions.getVersionRequest]: state => ({ ...state, processingVersion: true }),
-    [actions.getVersionFailure]: state => ({ ...state, processingVersion: false }),
-    [actions.getVersionSuccess]: (state, { payload }) => {
-        const currentVersion = state.dnsVersion === 'undefined' ? 0 : state.dnsVersion;
-
-        if (payload && versionCompare(currentVersion, payload.new_version) === -1) {
+const dashboard = handleActions(
+    {
+        [actions.dnsStatusRequest]: state => ({ ...state, processing: true }),
+        [actions.dnsStatusFailure]: state => ({ ...state, processing: false }),
+        [actions.dnsStatusSuccess]: (state, { payload }) => {
             const {
-                announcement_url: announcementUrl,
-                new_version: newVersion,
-                can_autoupdate: canAutoUpdate,
+                version,
+                running,
+                dns_port: dnsPort,
+                dns_addresses: dnsAddresses,
+                upstream_dns: upstreamDns,
+                bootstrap_dns: bootstrapDns,
+                all_servers: allServers,
+                protection_enabled: protectionEnabled,
+                language,
+                http_port: httpPort,
             } = payload;
+            const newState = {
+                ...state,
+                isCoreRunning: running,
+                processing: false,
+                dnsVersion: version,
+                dnsPort,
+                dnsAddresses,
+                upstreamDns: upstreamDns.join('\n'),
+                bootstrapDns: bootstrapDns.join('\n'),
+                allServers,
+                protectionEnabled,
+                language,
+                httpPort,
+            };
+            return newState;
+        },
+
+        [actions.enableDnsRequest]: state => ({ ...state, processing: true }),
+        [actions.enableDnsFailure]: state => ({ ...state, processing: false }),
+        [actions.enableDnsSuccess]: (state) => {
+            const newState = { ...state, isCoreRunning: !state.isCoreRunning, processing: false };
+            return newState;
+        },
+
+        [actions.disableDnsRequest]: state => ({ ...state, processing: true }),
+        [actions.disableDnsFailure]: state => ({ ...state, processing: false }),
+        [actions.disableDnsSuccess]: (state) => {
+            const newState = { ...state, isCoreRunning: !state.isCoreRunning, processing: false };
+            return newState;
+        },
+
+        [actions.getVersionRequest]: state => ({ ...state, processingVersion: true }),
+        [actions.getVersionFailure]: state => ({ ...state, processingVersion: false }),
+        [actions.getVersionSuccess]: (state, { payload }) => {
+            const currentVersion = state.dnsVersion === 'undefined' ? 0 : state.dnsVersion;
+
+            if (payload && versionCompare(currentVersion, payload.new_version) === -1) {
+                const {
+                    announcement_url: announcementUrl,
+                    new_version: newVersion,
+                    can_autoupdate: canAutoUpdate,
+                } = payload;
+
+                const newState = {
+                    ...state,
+                    announcementUrl,
+                    newVersion,
+                    canAutoUpdate,
+                    isUpdateAvailable: true,
+                    processingVersion: false,
+                };
+                return newState;
+            }
+
+            return {
+                ...state,
+                processingVersion: false,
+            };
+        },
+
+        [actions.getUpdateRequest]: state => ({ ...state, processingUpdate: true }),
+        [actions.getUpdateFailure]: state => ({ ...state, processingUpdate: false }),
+        [actions.getUpdateSuccess]: (state) => {
+            const newState = { ...state, processingUpdate: false };
+            return newState;
+        },
+
+        [actions.toggleProtectionRequest]: state => ({ ...state, processingProtection: true }),
+        [actions.toggleProtectionFailure]: state => ({ ...state, processingProtection: false }),
+        [actions.toggleProtectionSuccess]: (state) => {
+            const newState = {
+                ...state,
+                protectionEnabled: !state.protectionEnabled,
+                processingProtection: false,
+            };
+            return newState;
+        },
+
+        [actions.handleUpstreamChange]: (state, { payload }) => {
+            const { upstreamDns } = payload;
+            return { ...state, upstreamDns };
+        },
+
+        [actions.getLanguageSuccess]: (state, { payload }) => {
+            const newState = { ...state, language: payload };
+            return newState;
+        },
+
+        [actions.getClientsRequest]: state => ({ ...state, processingClients: true }),
+        [actions.getClientsFailure]: state => ({ ...state, processingClients: false }),
+        [actions.getClientsSuccess]: (state, { payload }) => {
+            const newState = {
+                ...state,
+                clients: payload.clients,
+                autoClients: payload.autoClients,
+                processingClients: false,
+            };
+            return newState;
+        },
+
+        [actions.getDnsSettingsRequest]: state => ({ ...state, processingDnsSettings: true }),
+        [actions.getDnsSettingsFailure]: state => ({ ...state, processingDnsSettings: false }),
+        [actions.getDnsSettingsSuccess]: (state, { payload }) => {
+            const {
+                upstream_dns: upstreamDns,
+                bootstrap_dns: bootstrapDns,
+                all_servers: allServers,
+            } = payload;
+
+            return {
+                ...state,
+                allServers,
+                upstreamDns: (upstreamDns && upstreamDns.join('\n')) || '',
+                bootstrapDns: (bootstrapDns && bootstrapDns.join('\n')) || '',
+                processingDnsSettings: false,
+            };
+        },
+    },
+    {
+        processing: true,
+        isCoreRunning: false,
+        processingVersion: true,
+        processingFiltering: true,
+        processingClients: true,
+        processingUpdate: false,
+        processingDnsSettings: true,
+        upstreamDns: '',
+        bootstrapDns: '',
+        allServers: false,
+        protectionEnabled: false,
+        processingProtection: false,
+        httpPort: 80,
+        dnsPort: 53,
+        dnsAddresses: [],
+        dnsVersion: '',
+        clients: [],
+        autoClients: [],
+    },
+);
+
+const dhcp = handleActions(
+    {
+        [actions.getDhcpStatusRequest]: state => ({ ...state, processing: true }),
+        [actions.getDhcpStatusFailure]: state => ({ ...state, processing: false }),
+        [actions.getDhcpStatusSuccess]: (state, { payload }) => {
+            const { static_leases: staticLeases, ...values } = payload;
 
             const newState = {
                 ...state,
-                announcementUrl,
-                newVersion,
-                canAutoUpdate,
-                isUpdateAvailable: true,
-                processingVersion: false,
+                staticLeases,
+                processing: false,
+                ...values,
+            };
+
+            return newState;
+        },
+
+        [actions.getDhcpInterfacesRequest]: state => ({ ...state, processingInterfaces: true }),
+        [actions.getDhcpInterfacesFailure]: state => ({ ...state, processingInterfaces: false }),
+        [actions.getDhcpInterfacesSuccess]: (state, { payload }) => {
+            const newState = {
+                ...state,
+                interfaces: payload,
+                processingInterfaces: false,
             };
             return newState;
-        }
+        },
 
-        return {
-            ...state,
-            processingVersion: false,
-        };
+        [actions.findActiveDhcpRequest]: state => ({ ...state, processingStatus: true }),
+        [actions.findActiveDhcpFailure]: state => ({ ...state, processingStatus: false }),
+        [actions.findActiveDhcpSuccess]: (state, { payload }) => {
+            const { other_server: otherServer, static_ip: staticIP } = payload;
+
+            const newState = {
+                ...state,
+                check: {
+                    otherServer,
+                    staticIP,
+                },
+                processingStatus: false,
+            };
+            return newState;
+        },
+
+        [actions.toggleDhcpRequest]: state => ({ ...state, processingDhcp: true }),
+        [actions.toggleDhcpFailure]: state => ({ ...state, processingDhcp: false }),
+        [actions.toggleDhcpSuccess]: (state) => {
+            const { config } = state;
+            const newConfig = { ...config, enabled: !config.enabled };
+            const newState = {
+                ...state,
+                config: newConfig,
+                check: null,
+                processingDhcp: false,
+            };
+            return newState;
+        },
+
+        [actions.setDhcpConfigRequest]: state => ({ ...state, processingConfig: true }),
+        [actions.setDhcpConfigFailure]: state => ({ ...state, processingConfig: false }),
+        [actions.setDhcpConfigSuccess]: (state, { payload }) => {
+            const { config } = state;
+            const newConfig = { ...config, ...payload };
+            const newState = { ...state, config: newConfig, processingConfig: false };
+            return newState;
+        },
+
+        [actions.toggleLeaseModal]: (state) => {
+            const newState = {
+                ...state,
+                isModalOpen: !state.isModalOpen,
+            };
+            return newState;
+        },
+
+        [actions.addStaticLeaseRequest]: state => ({ ...state, processingAdding: true }),
+        [actions.addStaticLeaseFailure]: state => ({ ...state, processingAdding: false }),
+        [actions.addStaticLeaseSuccess]: (state, { payload }) => {
+            const { ip, mac, hostname } = payload;
+            const newLease = {
+                ip,
+                mac,
+                hostname: hostname || '',
+            };
+            const leases = [...state.staticLeases, newLease];
+            const newState = {
+                ...state,
+                staticLeases: leases,
+                processingAdding: false,
+            };
+            return newState;
+        },
+
+        [actions.removeStaticLeaseRequest]: state => ({ ...state, processingDeleting: true }),
+        [actions.removeStaticLeaseFailure]: state => ({ ...state, processingDeleting: false }),
+        [actions.removeStaticLeaseSuccess]: (state, { payload }) => {
+            const leaseToRemove = payload.ip;
+            const leases = state.staticLeases.filter(item => item.ip !== leaseToRemove);
+            const newState = {
+                ...state,
+                staticLeases: leases,
+                processingDeleting: false,
+            };
+            return newState;
+        },
     },
-
-    [actions.getUpdateRequest]: state => ({ ...state, processingUpdate: true }),
-    [actions.getUpdateFailure]: state => ({ ...state, processingUpdate: false }),
-    [actions.getUpdateSuccess]: (state) => {
-        const newState = { ...state, processingUpdate: false };
-        return newState;
+    {
+        processing: true,
+        processingStatus: false,
+        processingInterfaces: false,
+        processingDhcp: false,
+        processingConfig: false,
+        processingAdding: false,
+        processingDeleting: false,
+        config: {
+            enabled: false,
+        },
+        check: null,
+        leases: [],
+        staticLeases: [],
+        isModalOpen: false,
     },
-
-    [actions.toggleProtectionRequest]: state => ({ ...state, processingProtection: true }),
-    [actions.toggleProtectionFailure]: state => ({ ...state, processingProtection: false }),
-    [actions.toggleProtectionSuccess]: (state) => {
-        const newState = {
-            ...state,
-            protectionEnabled: !state.protectionEnabled,
-            processingProtection: false,
-        };
-        return newState;
-    },
-
-    [actions.handleUpstreamChange]: (state, { payload }) => {
-        const { upstreamDns } = payload;
-        return { ...state, upstreamDns };
-    },
-
-    [actions.getLanguageSuccess]: (state, { payload }) => {
-        const newState = { ...state, language: payload };
-        return newState;
-    },
-
-    [actions.getClientsRequest]: state => ({ ...state, processingClients: true }),
-    [actions.getClientsFailure]: state => ({ ...state, processingClients: false }),
-    [actions.getClientsSuccess]: (state, { payload }) => {
-        const newState = {
-            ...state,
-            clients: payload.clients,
-            autoClients: payload.autoClients,
-            processingClients: false,
-        };
-        return newState;
-    },
-}, {
-    processing: true,
-    isCoreRunning: false,
-    processingVersion: true,
-    processingFiltering: true,
-    processingClients: true,
-    processingUpdate: false,
-    upstreamDns: '',
-    bootstrapDns: '',
-    allServers: false,
-    protectionEnabled: false,
-    processingProtection: false,
-    httpPort: 80,
-    dnsPort: 53,
-    dnsAddresses: [],
-    dnsVersion: '',
-    clients: [],
-    autoClients: [],
-});
-
-const dhcp = handleActions({
-    [actions.getDhcpStatusRequest]: state => ({ ...state, processing: true }),
-    [actions.getDhcpStatusFailure]: state => ({ ...state, processing: false }),
-    [actions.getDhcpStatusSuccess]: (state, { payload }) => {
-        const {
-            static_leases: staticLeases,
-            ...values
-        } = payload;
-
-        const newState = {
-            ...state,
-            staticLeases,
-            processing: false,
-            ...values,
-        };
-
-        return newState;
-    },
-
-    [actions.getDhcpInterfacesRequest]: state => ({ ...state, processingInterfaces: true }),
-    [actions.getDhcpInterfacesFailure]: state => ({ ...state, processingInterfaces: false }),
-    [actions.getDhcpInterfacesSuccess]: (state, { payload }) => {
-        const newState = {
-            ...state,
-            interfaces: payload,
-            processingInterfaces: false,
-        };
-        return newState;
-    },
-
-    [actions.findActiveDhcpRequest]: state => ({ ...state, processingStatus: true }),
-    [actions.findActiveDhcpFailure]: state => ({ ...state, processingStatus: false }),
-    [actions.findActiveDhcpSuccess]: (state, { payload }) => {
-        const {
-            other_server: otherServer,
-            static_ip: staticIP,
-        } = payload;
-
-        const newState = {
-            ...state,
-            check: {
-                otherServer,
-                staticIP,
-            },
-            processingStatus: false,
-        };
-        return newState;
-    },
-
-    [actions.toggleDhcpRequest]: state => ({ ...state, processingDhcp: true }),
-    [actions.toggleDhcpFailure]: state => ({ ...state, processingDhcp: false }),
-    [actions.toggleDhcpSuccess]: (state) => {
-        const { config } = state;
-        const newConfig = { ...config, enabled: !config.enabled };
-        const newState = {
-            ...state, config: newConfig, check: null, processingDhcp: false,
-        };
-        return newState;
-    },
-
-    [actions.setDhcpConfigRequest]: state => ({ ...state, processingConfig: true }),
-    [actions.setDhcpConfigFailure]: state => ({ ...state, processingConfig: false }),
-    [actions.setDhcpConfigSuccess]: (state, { payload }) => {
-        const { config } = state;
-        const newConfig = { ...config, ...payload };
-        const newState = { ...state, config: newConfig, processingConfig: false };
-        return newState;
-    },
-
-    [actions.toggleLeaseModal]: (state) => {
-        const newState = {
-            ...state,
-            isModalOpen: !state.isModalOpen,
-        };
-        return newState;
-    },
-
-    [actions.addStaticLeaseRequest]: state => ({ ...state, processingAdding: true }),
-    [actions.addStaticLeaseFailure]: state => ({ ...state, processingAdding: false }),
-    [actions.addStaticLeaseSuccess]: (state, { payload }) => {
-        const {
-            ip, mac, hostname,
-        } = payload;
-        const newLease = {
-            ip,
-            mac,
-            hostname: hostname || '',
-        };
-        const leases = [...state.staticLeases, newLease];
-        const newState = {
-            ...state,
-            staticLeases: leases,
-            processingAdding: false,
-        };
-        return newState;
-    },
-
-    [actions.removeStaticLeaseRequest]: state => ({ ...state, processingDeleting: true }),
-    [actions.removeStaticLeaseFailure]: state => ({ ...state, processingDeleting: false }),
-    [actions.removeStaticLeaseSuccess]: (state, { payload }) => {
-        const leaseToRemove = payload.ip;
-        const leases = state.staticLeases.filter(item => item.ip !== leaseToRemove);
-        const newState = {
-            ...state,
-            staticLeases: leases,
-            processingDeleting: false,
-        };
-        return newState;
-    },
-}, {
-    processing: true,
-    processingStatus: false,
-    processingInterfaces: false,
-    processingDhcp: false,
-    processingConfig: false,
-    processingAdding: false,
-    processingDeleting: false,
-    config: {
-        enabled: false,
-    },
-    check: null,
-    leases: [],
-    staticLeases: [],
-    isModalOpen: false,
-});
+);
 
 export default combineReducers({
     settings,