daxi20/AdGuardHome
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Pull request:* all: fix all staticcheck simplification and unused warnings

Browse Source 
Merge in DNS/adguard-home from 2270-fix-s-u-warnings to master

Squashed commit of the following:

commit 03e0f78bd471057007c2d4042ee26eda2bbc9b29
Merge: 50dc3ef5c 7e16fda57
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Fri Nov 6 11:54:09 2020 +0300

    Merge branch 'master' into 2270-fix-s-u-warnings

commit 50dc3ef5c44a5fdc941794c26784b0c44d7b5aa0
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Thu Nov 5 19:48:54 2020 +0300

    * all: improve code quality

commit d6d804f759ce3e47154a389b427550e72c4b9090
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Thu Nov 5 18:03:35 2020 +0300

    * all: fix all staticcheck simplification and unused warnings

    Closes #2270.
This commit is contained in:
Eugene Burkov
2020-11-06 12:15:08 +03:00
parent 7e16fda57b
commit 3e1f922252
24 changed files with 159 additions and 210 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
internal/stats/stats_test.go
View File

@@ -10,7 +10,7 @@ import (
"github.com/stretchr/testify/assert"
)
func UIntArrayEquals(a []uint64, b []uint64) bool {
func UIntArrayEquals(a, b []uint64) bool {
if len(a) != len(b) {
return false
}
@@ -83,8 +83,7 @@ func TestStats(t *testing.T) {
}
func TestLargeNumbers(t *testing.T) {
var hour int32
hour = 1
var hour int32 = 1
newID := func() uint32 {
// use "atomic" to make Go race detector happy
return uint32(atomic.LoadInt32(&hour))
@@ -144,6 +143,7 @@ func aggregateDataPerDay(firstID uint32) int {
}
return len(a)
}
func TestAggregateDataPerTimeUnit(t *testing.T) {
for i := 0; i != 25; i++ {
alen := aggregateDataPerDay(uint32(i))