daxi20/AdGuardHome
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix data race condition in test

Browse Source
This commit is contained in:
Reinaldo de Souza Jr
2020-12-05 18:09:42 +01:00
parent aff09211b2
commit 6e6ee9697a
1 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
internal/dnsforward/dnsforward_test.go
View File

@@ -757,7 +757,10 @@ func TestBlockedDNSRebinding(t *testing.T) {
{Name: "192-168-1-250.nip.io.", Qtype: dns.TypeA, Qclass: dns.ClassINET}, {Name: "192-168-1-250.nip.io.", Qtype: dns.TypeA, Qclass: dns.ClassINET},
} }
s.Lock()
s.conf.RebindingProtectionEnabled = true s.conf.RebindingProtectionEnabled = true
s.Unlock()
reply, err := dns.Exchange(&req, addr.String()) reply, err := dns.Exchange(&req, addr.String())
if err != nil { if err != nil {
t.Fatalf("Couldn't talk to server %s: %s", addr, err) t.Fatalf("Couldn't talk to server %s: %s", addr, err)
@@ -776,7 +779,10 @@ func TestBlockedDNSRebinding(t *testing.T) {
t.Fatalf("DNS server %s returned wrong answer instead of 0.0.0.0: %v", addr, a.A) t.Fatalf("DNS server %s returned wrong answer instead of 0.0.0.0: %v", addr, a.A)
} }
s.Lock()
s.conf.RebindingProtectionEnabled = false s.conf.RebindingProtectionEnabled = false
s.Unlock()
reply, err = dns.Exchange(&req, addr.String()) reply, err = dns.Exchange(&req, addr.String())
if err != nil { if err != nil {
t.Fatalf("Couldn't talk to server %s: %s", addr, err) t.Fatalf("Couldn't talk to server %s: %s", addr, err)
@@ -795,10 +801,13 @@ func TestBlockedDNSRebinding(t *testing.T) {
t.Fatalf("DNS server %s returned wrong answer instead of 192.168.1.250: %v", addr, a.A) t.Fatalf("DNS server %s returned wrong answer instead of 192.168.1.250: %v", addr, a.A)
} }
s.Lock()
s.conf.RebindingProtectionEnabled = true s.conf.RebindingProtectionEnabled = true
s.rebinding, _ = newRebindChecker([]string{ s.rebinding, _ = newRebindChecker([]string{
"||nip.io^", "||nip.io^",
}) })
s.Unlock()
reply, err = dns.Exchange(&req, addr.String()) reply, err = dns.Exchange(&req, addr.String())
if err != nil { if err != nil {
t.Fatalf("Couldn't talk to server %s: %s", addr, err) t.Fatalf("Couldn't talk to server %s: %s", addr, err)