potential bug fix

This commit is contained in:
Nick Peng
2018-12-31 22:41:49 +08:00
parent 46f505ff06
commit 379447cfd2
2 changed files with 13 additions and 0 deletions

View File

@@ -1075,6 +1075,7 @@ static int _fast_ping_process_icmp(struct ping_host_struct *ping_host, struct ti
{
if (recv_ping_host->addr_len == from_len && memcmp(&recv_ping_host->addr, &from, from_len) == 0 && recv_ping_host->sid == sid &&
recv_ping_host->cookie == cookie) {
_fast_ping_host_get(recv_ping_host);
break;
}
}
@@ -1086,6 +1087,7 @@ static int _fast_ping_process_icmp(struct ping_host_struct *ping_host, struct ti
}
if (recv_ping_host->seq != seq) {
_fast_ping_host_put(recv_ping_host);
tlog(TLOG_ERROR, "seq num mismatch, expect %u, real %u", recv_ping_host->seq, seq);
return -1;
}
@@ -1103,6 +1105,7 @@ static int _fast_ping_process_icmp(struct ping_host_struct *ping_host, struct ti
_fast_ping_host_remove(recv_ping_host);
}
_fast_ping_host_put(recv_ping_host);
return 0;
errout:
return -1;
@@ -1195,6 +1198,7 @@ static int _fast_ping_process_udp(struct ping_host_struct *ping_host, struct tim
hash_for_each_possible(ping.addrmap, recv_ping_host, addr_node, addrkey)
{
if (recv_ping_host->addr_len == from_len && memcmp(&recv_ping_host->addr, &from, from_len) == 0 && recv_ping_host->sid == sid) {
_fast_ping_host_get(recv_ping_host);
break;
}
}
@@ -1219,6 +1223,8 @@ static int _fast_ping_process_udp(struct ping_host_struct *ping_host, struct tim
_fast_ping_host_remove(recv_ping_host);
}
_fast_ping_host_put(recv_ping_host);
return 0;
errout:
return -1;