Update to actions/upload-artifact@v4

Most importantly update to kelunik/acme v1.0.1 to fix https://github.com/kelunik/acme/issues/41.

.github/workflows/ci.yml

@@ -0,0 +1,81 @@
+name: Continuous Integration
+
+on:
+  - push
+  - pull_request
+
+jobs:
+  tests:
+    strategy:
+      matrix:
+        include:
+          - operating-system: 'ubuntu-latest'
+            php-version: '8.1'
+
+    name: PHP ${{ matrix.php-version }} ${{ matrix.job-description }}
+
+    runs-on: ${{ matrix.operating-system }}
+
+    steps:
+      - name: Set git to use LF
+        run: |
+          git config --global core.autocrlf false
+          git config --global core.eol lf
+
+      - name: Checkout code
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+
+      - name: Setup PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: ${{ matrix.php-version }}
+          ini-values: zend.assertions=1, assert.exception=1
+        env:
+          update: true
+
+      - name: Get Composer cache directory
+        id: composer-cache
+        run: echo "dir=$(composer config cache-dir)" >> $GITHUB_OUTPUT
+        shell: bash
+
+      - name: Cache dependencies
+        uses: actions/cache@v3
+        with:
+          path: ${{ steps.composer-cache.outputs.dir }}
+          key: composer-${{ runner.os }}-${{ matrix.php-version }}-${{ hashFiles('**/composer.*') }}-${{ matrix.composer-flags }}
+          restore-keys: |
+            composer-${{ runner.os }}-${{ matrix.php-version }}-${{ hashFiles('**/composer.*') }}-
+            composer-${{ runner.os }}-${{ matrix.php-version }}-
+            composer-${{ runner.os }}-
+            composer-
+
+      - name: Install dependencies
+        uses: nick-invision/retry@v2
+        with:
+          timeout_minutes: 5
+          max_attempts: 5
+          retry_wait_seconds: 30
+          command: |
+            composer update --optimize-autoloader --no-interaction --no-progress ${{ matrix.composer-flags }}
+            composer info -D
+
+      - name: Run tests
+        run: vendor/bin/phpunit ${{ matrix.phpunit-flags }}
+
+      - name: Run style fixer
+        env:
+          PHP_CS_FIXER_IGNORE_ENV: 1
+        run: vendor/bin/php-cs-fixer --diff --dry-run -v fix
+        if: matrix.php-cs-fixer != 'none'
+
+      - name: Build phar
+        run: php -dphar.readonly=0 vendor/bin/phar-builder package
+
+      - name: Upload phar
+        uses: actions/upload-artifact@v4
+        with:
+          name: acme-client.phar
+          path: |
+            build/acme-client.phar

doc/advanced-usage.md

@@ -5,7 +5,7 @@ Please read the document about [basic usage](./usage.md) first.
 ## Register an Account
 
 ```
-acme-client setup --email me@example.com
+acme-client setup --agree-terms --email me@example.com
 ```
 
 After a successful registration you're able to issue certificates.

src/AcmeFactory.php

@@ -2,7 +2,6 @@
 
 namespace Kelunik\AcmeClient;
 
-use Amp\ByteStream\ResourceOutputStream;
 use Amp\Log\ConsoleFormatter;
 use Amp\Log\StreamHandler;
 use Kelunik\Acme\AcmeClient;

src/Commands/Issue.php

@@ -143,7 +143,7 @@ class Issue implements Command
             [$errors] = yield AcmeClient\concurrentMap(
                 $concurrency,
                 $order->getAuthorizationUrls(),
-                function ($authorizationUrl, $i) use ($acme, $key, $domains, $docRoots, $user) {
+                function ($authorizationUrl) use ($acme, $key, $domains, $docRoots, $user) {
                     /** @var Authorization $authorization */
                     $authorization = yield $acme->getAuthorization($authorizationUrl);
 
@@ -161,8 +161,14 @@ class Issue implements Command
                         throw new AcmeException('Unknown identifier returned: ' . $name);
                     }
 
-                    return yield from $this->solveChallenge($acme, $key, $authorization, $domains[$i], $docRoots[$i],
-                        $user);
+                    return yield from $this->solveChallenge(
+                        $acme,
+                        $key,
+                        $authorization,
+                        $name,
+                        $docRoots[$index],
+                        $user
+                    );
                 }
             );